This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(dropdown): add optional placement and respect bootstrap classes #6358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #6030 |
|
Fixes #6323 |
|
Fixes #5767 |
|
Partially fixes: #4762 |
Add an optional dropdown-placement attribute setting much like the tooltips'. If it is specified then bootstrap's dropup and dropdown-menu-right classes will be ignored. Updated positioning of the dropdown menu to always use the position service. Ensured that dropup and dropdown-menu-right will be respected for append-to and append-to-body dropdowns. Updated positioning service to return the element when looking for the offsetParent if the element is not statically positioned.
farooqu
force-pushed
the
dropdown-placement
branch
from
57bb422 to
79407c4
Compare
|
This will need tests - can you add a test that it places it correctly? |
|
Guys, is there any progress on it? |
|
This fixes quite a few problems. Any chance this is going to be merged in soon? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional dropdown-placement attribute setting much like the
tooltips'. If it is specified then bootstrap's dropup and
dropdown-menu-right classes will be ignored. Updated positioning of the
dropdown menu to always use the position service. Ensured that dropup
and dropdown-menu-right will be respected for append-to and
append-to-body dropdowns. Updated positioning service to return the
element when looking for the offsetParent if the element is not
statically positioned.